Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues after flake8 update 5 → 6 #343

Closed
wants to merge 2 commits into from
Closed

Fix CI issues after flake8 update 5 → 6 #343

wants to merge 2 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Dec 1, 2022

PyCQA/flake8#1760

Fixes #342.

@arthurdejong
Copy link
Owner

For now I've pushed 7a91a98 to keep the working flake8. I'm not happy about the dropping of support for inline comments in the ignore list in flake8 because it makes the ignore list much more difficult to manage and I'm hoping the support for comments will be restored at some point.

@DimitriPapadopoulos
Copy link
Contributor Author

Support for comments will not be restored. Such comments are considered to be a syntax error.

See PyCQA/flake8#1750.

@arthurdejong
Copy link
Owner

I've seen those comments and I think they are wrong. ;) Similar inline comments are supported in a lot of places in tox.ini or setup.cfg so I don't see why a list of ignores in flake8 is so special that we should expect different behaviour.

@DimitriPapadopoulos
Copy link
Contributor Author

If the maintainer thinks otherwise, this will not be fixed. We need arguments from the documentation or normative documents such as PEPs.

The Python Packaging User Guide doesn't say much on the subject:

setup.cfg

setup.cfg is an ini file that contains option defaults for setup.py commands. For an example, see the setup.cfg in the PyPA sample project.

The Python documentation, in Syntax of config files, is even less informative:

The Distutils configuration files all have the same syntax. The config files are grouped into sections. There is one section for each Distutils command, plus a global section for global options that affect every command. Each section consists of one option per line, specified as option=value.

Unfortunately, INI files lack a real standard. From Wikipedia:

In some implementations, a comment may begin anywhere on a line after a space (inline comments), including on the same line after properties or section declarations.

var = a       ; This is an inline comment
foo = bar     # This is another inline comment

In others, including the WinAPI function GetPrivateProfileString, comments must occur on lines by themselves.

PyCQA/flake8#1760

Plugin flake8-quotes is now compatible with flake8 6.0,
starting with release 3.3.2:
zheller/flake8-quotes#111 is merged.
@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jun 18, 2023

Update to require flake8-quotes>=3.3.2 to be compatible with flake8 6.0.

I don't know how to require this version only for flake8>=6.

@DimitriPapadopoulos DimitriPapadopoulos closed this by deleting the head repository May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI issues after flake8 has been bumped to 6.0.0
2 participants